Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: restructure transactions and define CODEOWNERS #13733

Open
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

httpJunkie
Copy link
Contributor

@httpJunkie httpJunkie commented Feb 26, 2025

Description

Create a transactions directory that contains code owned by the Transactions team. Focusing only on the app/components/Views directory. A follow up task could be created to tackle app/components/UI if needed.

Transaction Views

app/
  components/
    Views/
      transactions/             # (New Dir) Transactions Team Owned
        SmartTransactionStatus/ # (moved from app/components/Views/SmartTransactionStatus)

Directory Ownership in CODEOWNERS

The CODEOWNERS file is updated to include transactions views:

# Transactions Team
app/components/Views/Transactions/   @MetaMask/transactions

Implementation Plan

  1. Create the new directory structure under app/components/Views/Transactions/
  2. Move transaction-related Views into this structure
  3. Update imports throughout codebase to reflect the new path
  4. Ensure all tests pass with the new structure

Related issues

Fixes: Phase 1 for Transactions team in reorganization for Mobile codebase.

Manual testing steps

  1. Ensure the application and tests run as normal. There is no functional change for this PR, only reorganization of files.

Screenshots/Recordings

Before

After

STXStatus_Success

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@httpJunkie httpJunkie requested a review from a team as a code owner February 26, 2025 09:58
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-transactions Transactions team label Feb 26, 2025
@httpJunkie httpJunkie self-assigned this Feb 26, 2025
@httpJunkie httpJunkie requested a review from a team as a code owner February 27, 2025 17:43
@httpJunkie httpJunkie added release-7.42.0 Issue or pull request that will be included in release 7.42.0 Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 27, 2025
@MetaMask MetaMask deleted a comment from github-actions bot Mar 3, 2025
@httpJunkie httpJunkie added Run Smoke E2E Triggers smoke e2e on Bitrise No E2E Smoke Needed If the PR does not need E2E smoke test run and removed Run Smoke E2E Triggers smoke e2e on Bitrise No E2E Smoke Needed If the PR does not need E2E smoke test run labels Mar 3, 2025
@httpJunkie httpJunkie added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Mar 4, 2025
@MetaMask MetaMask deleted a comment from github-actions bot Mar 4, 2025
@httpJunkie httpJunkie added the Run Smoke E2E Triggers smoke e2e on Bitrise label Mar 10, 2025
@MetaMask MetaMask deleted a comment from github-actions bot Mar 10, 2025
@MetaMask MetaMask deleted a comment from github-actions bot Mar 10, 2025
@MetaMask MetaMask deleted a comment from sonarqubecloud bot Mar 10, 2025
@MetaMask MetaMask deleted a comment from github-actions bot Mar 10, 2025
@httpJunkie httpJunkie added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Mar 10, 2025
Copy link
Contributor

github-actions bot commented Mar 10, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 9f1e6f3
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2bff9a6e-ffd2-492a-a99b-34da833849f4

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@httpJunkie
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

dan437
dan437 previously approved these changes Mar 11, 2025
Copy link
Member

@OGPoyraz OGPoyraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmation changes LGTM

OGPoyraz
OGPoyraz previously approved these changes Mar 12, 2025
@httpJunkie httpJunkie added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Mar 12, 2025
Copy link
Contributor

github-actions bot commented Mar 12, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 91c5e4f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/faad2522-6562-4168-8463-3d8431704c99

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@httpJunkie httpJunkie added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Mar 13, 2025
Copy link
Contributor

github-actions bot commented Mar 13, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 41bcf25
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/bf35b477-17c7-4bfe-8ba7-1b2f7a83f58e

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-7.42.0 Issue or pull request that will be included in release 7.42.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-transactions Transactions team
Projects
Status: Needs dev review
Development

Successfully merging this pull request may close these issues.

4 participants