Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify logging #1185

Merged
merged 2 commits into from
Feb 21, 2025
Merged

Simplify logging #1185

merged 2 commits into from
Feb 21, 2025

Conversation

jfrost-mo
Copy link
Member

@jfrost-mo jfrost-mo commented Feb 20, 2025 •
edited
Loading

Ensures the logs are output while the task is running and are recorded to a file.

Contribution checklist

Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.

  • Documentation has been updated to reflect change.
  • New code has tests, and affected old tests have been updated.
  • All tests and CI checks pass.
  • Ensured the pull request title is descriptive.
  • Conda lock files have been updated if dependencies have changed.
  • Attributed any Generative AI, such as GitHub Copilot, used in this PR.
  • Marked the PR as ready to review.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 20, 2025 •
edited
Loading

Coverage

@jfrost-mo jfrost-mo requested a review from jwarner8 February 20, 2025 16:18
@jfrost-mo jfrost-mo self-assigned this Feb 20, 2025
@jfrost-mo jfrost-mo added the enhancement New feature or request label Feb 20, 2025
@jfrost-mo jfrost-mo marked this pull request as ready for review February 20, 2025 16:19
jwarner8
jwarner8 approved these changes Feb 20, 2025
View reviewed changes
@jfrost-mo
Simplify log level calculation logic
542917b 
This makes the full logs be outputted to the CSET.log file. The test is
also updated to accommodate this change.
@jfrost-mo
Don't unnecessarily capture log output of CSET bake
6fc3bad 
This allows the CSET bake logs to be shown while it is running, and also
when it succeeds.
@jfrost-mo jfrost-mo requested a review from jwarner8 February 21, 2025 10:55
@jfrost-mo jfrost-mo merged commit cccc7dc into main Feb 21, 2025
9 checks passed
@jfrost-mo jfrost-mo deleted the simplify_logging branch February 21, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwarner8 jwarner8 jwarner8 approved these changes

Assignees

@jfrost-mo jfrost-mo

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jfrost-mo @jwarner8