Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix timeseries ylim based on JSON entries, and add gridlines. #1175

Merged
merged 9 commits into from
Feb 20, 2025
Merged

Fix timeseries ylim based on JSON entries, and add gridlines. #1175

merged 9 commits into from
Feb 20, 2025

Conversation

jwarner8
Copy link
Contributor

Fixes #1172

Contribution checklist

Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.

  • Documentation has been updated to reflect change.
  • New code has tests, and affected old tests have been updated.
  • All tests and CI checks pass.
  • Ensured the pull request title is descriptive.
  • Conda lock files have been updated if dependencies have changed.
  • Attributed any Generative AI, such as GitHub Copilot, used in this PR.
  • Marked the PR as ready to review.

@jwarner8 jwarner8 self-assigned this Feb 19, 2025
@jwarner8 jwarner8 requested a review from jfrost-mo February 19, 2025 16:41
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 19, 2025 •
edited
Loading

Coverage

jfrost-mo
jfrost-mo reviewed Feb 20, 2025
View reviewed changes
Copy link
Member

@jfrost-mo jfrost-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, some small coding suggestions before it is merged.

@jwarner8 jwarner8 requested a review from jfrost-mo February 20, 2025 12:26
jfrost-mo
jfrost-mo approved these changes Feb 20, 2025
View reviewed changes
Copy link
Member

@jfrost-mo jfrost-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jwarner8 jwarner8 merged commit 2419a91 into main Feb 20, 2025
9 checks passed
@jwarner8 jwarner8 deleted the timeseries_impr branch February 20, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfrost-mo jfrost-mo jfrost-mo approved these changes

Assignees

@jwarner8 jwarner8

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix time series plots ylim based on JSON vmin/vmax values, and gridlines
2 participants
@jwarner8 @jfrost-mo