Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip running dummy tasks #1120

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Skip running dummy tasks #1120

wants to merge 1 commit into from

Conversation

jfrost-mo
Copy link
Member

@jfrost-mo jfrost-mo commented Feb 4, 2025

This uses a new feature of cylc 8.4, and skips the job entirely.

The key consideration with this PR is portability, as not all sites might have cylc 8.4 yet.

Contribution checklist

Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.

  • Documentation has been updated to reflect change.
  • New code has tests, and affected old tests have been updated.
  • All tests and CI checks pass.
  • Ensured the pull request title is descriptive.
  • Conda lock files have been updated if dependencies have changed.
  • Attributed any Generative AI, such as GitHub Copilot, used in this PR.
  • Marked the PR as ready to review.

@jfrost-mo jfrost-mo added enhancement New feature or request small Small issue that should be quick to resolve labels Feb 4, 2025
@jfrost-mo jfrost-mo self-assigned this Feb 4, 2025
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Coverage

This uses a new feature of cylc 8.4, and skips the job entirely.
@jfrost-mo
Copy link
Member Author

Just tested, and as expected this doesn't work on cylc 8.3.6, so we probably can't merge this for a while. I wonder if there is a list of the cylc version of partners maintained somewhere?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request small Small issue that should be quick to resolve
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant