Skip to content

feat: keep edges and hide devices from sub-layers #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 5, 2025

Conversation

MegaRedHand
Copy link
Owner

@MegaRedHand MegaRedHand commented Apr 1, 2025

This PR makes viewgraph store all devices, but makes invisible devices not of the current layer (or above).

@MegaRedHand MegaRedHand marked this pull request as ready for review April 1, 2025 01:27
@pgallino
Copy link
Collaborator

pgallino commented Apr 1, 2025

Devices that are not part of the layer should be hidden in the Destination dropdown

image
image

@pgallino
Copy link
Collaborator

pgallino commented Apr 1, 2025

All edges should be highlighted if the host is connected to them

image

@pgallino
Copy link
Collaborator

pgallino commented Apr 1, 2025

Not sure what we should do with edge selection

image

@pgallino pgallino marked this pull request as draft April 3, 2025 15:03
@MegaRedHand
Copy link
Owner Author

I think we can disable the selected edge transparency feature now

@MegaRedHand MegaRedHand marked this pull request as ready for review April 5, 2025 14:02
@MegaRedHand MegaRedHand merged commit 325a6b5 into main Apr 5, 2025
3 checks passed
@MegaRedHand MegaRedHand deleted the hide-devices-from-sub-layers branch April 5, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants