Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various cosmetic changes and formatting #27503

Open
wants to merge 38 commits into
base: bugfix-2.1.x
Choose a base branch
from

Conversation

classicrocker883
Copy link
Contributor

@classicrocker883 classicrocker883 commented Oct 29, 2024

Description

Mostly cosmetic changes, basically just hit Format Document and made tweaks

  • Update spacing, syntax, comments, capitalize, spacing, and such to match likeness in code
    • This helps simplify code and adds better readability

Format:

  • Reformatted many Python (.py) script files (for spacing and readability):
    • buildroot\share\scripts
    • buildroot\share\PlatformIO\scripts
    • src\lcd\extui\ftdi_eve_touch_ui\ftdi_eve_lib\scripts
      Also updated comments, such as "help" and usage:, when running the script in a terminal

Some rearranging:

  • Fix runout/filament sensor spacing
  • Rearrange: marlinui.h, planner.cpp, creality/dwin.cpp
  • Arrange print_heater_state/s() in temperature.cpp to be inline with Temperature sensor IDs (src\inc\Conditionals-4-adv.h)

Added:

  • Group *** BARICUDA *** - gcode.h
  • Use GET_TEXT_F and MSG_... from language_en.h instead of literal Strings in CrealityUI dwin.cpp, which was a TODO:

Removed:

  • Remove redundant code:
    • Remove double nested #if ENABLED(AUTO_BED_LEVELING_UBL) from settings.cpp

Move from other PR

Updated fwretract.h|fwretract.cpp

  • Arrange/improve values + comments
  • M208 was missing seenval, which is used in M207 companion
  • Rearrange fwretract_settings_t struct to follow gcode example

Requirements

Benefits

Configurations

Related Issues

@thinkyhead
Copy link
Member

Arrange print_heater_state/s() to be inline with Temperature sensor IDs

The multi-hotend states are sorted to the end for the convenience of hosts to get the current hotend and bed temperature in the early part of the string, so those should not be moved to the front or rearranged based on the arbitrary order of heaters in the configuration files or elsewhere.

@classicrocker883
Copy link
Contributor Author

@thinkyhead ok I reverted that part in temperature.cpp

I added a couple changes in the planner files which were missed in the recent merge commit.

the only thing i'm not so sure about it utility.h - IAXIS_CHAR, is that fine or should be reverted?

This was referenced Mar 17, 2025
@classicrocker883 classicrocker883 changed the title Various cosmetic changes Various cosmetic changes and formatting Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants