-
-
Notifications
You must be signed in to change notification settings - Fork 19.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No lower Z after home #27188
No lower Z after home #27188
Conversation
Not sure why it behaves this way but it's unpleasant to see Z moving down after home ends. Worse when G34 is used just after home. You see Z moving up then down than up again. With same parameters in configuration once it worked like now
We have to allow for |
Ah, well some of that is correct. But we do have this sanity check: #if Z_HOME_TO_MAX && defined(Z_AFTER_HOMING) && DISABLED(ALLOW_Z_AFTER_HOMING)
#error "Z_AFTER_HOMING shouldn't be used with Z max homing to keep 'G28 Z' safe for end-of-print usage. Define ALLOW_Z_AFTER_HOMING to allow this at your own risk."
#endif |
e038a32
to
042cccb
Compare
What is weird here is that blame doesn't report any recent change in code in line changed. Then something else changed the behaviour |
c792921
to
37fb26b
Compare
There seems to be a little wave of confusion happening around here regarding how we manage Z raises and other Z moves for homing, probing, tramming, leveling, etc. I see growing interest in how raises differ when the position is trusted and known versus when it is not trusted or unknown, when the probe is deployed or requires manual deploy/stow versus when there is no probe or the probe is known to be stowed, or when the raise needs to account for a changeable Anyway, it couldn't hurt to do another complete and thorough audit of the homing, leveling, and probing code. As for this PR, I don't think it's entirely correct, at least not for everybody. Some will want their nozzle to move down closer to the bed after homing is completed, and right now this is the one supported way to accomplish that behavior without editing If there is some concern about bad behavior connected to |
I agree that there are a lot of different situations and different behaviours. What I noticed was that behaviour changed from my previous installed version. I though it was an error not considering that maybe it changed to fullfill someone else corner case. |
37d77d6
to
aa44542
Compare
Not sure why it behaves this way but it's unpleasant to see Z moving down after home ends.
Worse when G34 is used just after home. You see Z moving up then down then up again.
With same parameters in configuration once it worked like now