MarimerLLC · StefanOssendorf · Mar 22, 2025 · Mar 14, 2025 · Mar 22, 2025 · Mar 22, 2025
diff --git a/...enerator.AutoSerialization.CSharp/AutoSerializable/Discovery/FieldDefinitionsExtractor.cs b/...enerator.AutoSerialization.CSharp/AutoSerializable/Discovery/FieldDefinitionsExtractor.cs
@@ -106,26 +106,6 @@ private static List<FieldDeclarationSyntax> GetNonPublicIncludedFields(Definitio
       return serializableFields;
     }
 
-    /// <summary>
-    /// Get the field declarations for all fields which have been explicitly included in serialization
-    /// </summary>
-    /// <param name="extractionContext">The definition extraction context in which the extraction is being performed</param>
-    /// <param name="targetTypeDeclaration">The TypeDeclarationSyntax from which to extract the necessary data</param>
-    /// <returns>A readonly list of field declarations to be included in serialization</returns>
-    private static List<FieldDeclarationSyntax> GetAllIncludedFields(DefinitionExtractionContext extractionContext, TypeDeclarationSyntax targetTypeDeclaration)
-    {
-      List<FieldDeclarationSyntax> serializableFields;
-
-      // Get any private or protected fields that are opted in with the use of the [AutoSerialized] attribute
-      serializableFields = targetTypeDeclaration.Members.Where(
-        m => m is FieldDeclarationSyntax fieldDeclaration &&
-        extractionContext.IsFieldDecoratedWithAutoSerialized(fieldDeclaration))
-        .Cast<FieldDeclarationSyntax>()
-        .ToList();
-
-      return serializableFields;
-    }
-
     /// <summary>
     /// Determine if a field has one of the scopes requested by a caller
     /// </summary>

diff --git a/Source/Csla.test/BusyStatus/BusyStatusTests.cs b/Source/Csla.test/BusyStatus/BusyStatusTests.cs
      ItemWithAsynchRuleList items = ItemWithAsynchRuleList.GetListWithItems(dataPortal);
      items[0].ValidationComplete += async (_, _) =>
      {
        Assert.IsFalse(items.IsBusy);
        Assert.IsTrue(items.IsSavable);
        items = await items.SaveAsync();
        string actual = items[0].OperationResult;
        Assert.AreEqual("DataPortal_Update", actual);
      };

      items[0].RuleField = "some value";
diff --git a/.../cs/AutoSerialization/Csla.Generator.AutoSerialization.CSharp.TestObjects/EmailAddress.cs b/.../cs/AutoSerialization/Csla.Generator.AutoSerialization.CSharp.TestObjects/EmailAddress.cs

    public void SetState(SerializationInfo info)
    {
      Email = info.GetValue<string>("Email");
    }
  }
 }
	ItemWithAsynchRuleList items = ItemWithAsynchRuleList.GetListWithItems(dataPortal);
	items[0].ValidationComplete += async (_, _) =>
	{
	Assert.IsFalse(items.IsBusy);
Check warning on line 148 in Source/Csla.test/BusyStatus/BusyStatusTests.cs GitHub Actions / build `Do not assert inside 'async void' methods, local functions, or lambdas because they may not fail the test (https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0040)` Check warning on line 148 in Source/Csla.test/BusyStatus/BusyStatusTests.cs GitHub Actions / build `Do not assert inside 'async void' methods, local functions, or lambdas because they may not fail the test (https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0040)`
	Assert.IsTrue(items.IsSavable);
Check warning on line 149 in Source/Csla.test/BusyStatus/BusyStatusTests.cs GitHub Actions / build `Do not assert inside 'async void' methods, local functions, or lambdas because they may not fail the test (https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0040)` Check warning on line 149 in Source/Csla.test/BusyStatus/BusyStatusTests.cs GitHub Actions / build `Do not assert inside 'async void' methods, local functions, or lambdas because they may not fail the test (https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0040)`
	items = await items.SaveAsync();
	string actual = items[0].OperationResult;
	Assert.AreEqual("DataPortal_Update", actual);
Check warning on line 152 in Source/Csla.test/BusyStatus/BusyStatusTests.cs GitHub Actions / build `Do not assert inside 'async void' methods, local functions, or lambdas because they may not fail the test (https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0040)` Check warning on line 152 in Source/Csla.test/BusyStatus/BusyStatusTests.cs GitHub Actions / build `Do not assert inside 'async void' methods, local functions, or lambdas because they may not fail the test (https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0040)`
	};

	items[0].RuleField = "some value";

	public void SetState(SerializationInfo info)
	{
	Email = info.GetValue<string>("Email");
Check warning on line 37 in Source/Csla.Generators/cs/AutoSerialization/Csla.Generator.AutoSerialization.CSharp.TestObjects/EmailAddress.cs GitHub Actions / build `Possible null reference assignment.` Check warning on line 37 in Source/Csla.Generators/cs/AutoSerialization/Csla.Generator.AutoSerialization.CSharp.TestObjects/EmailAddress.cs GitHub Actions / build `Possible null reference assignment.`
	}
	}
	}