Add major version upgrade testing from previous versions to mysql_upgrade.test #3503
+6,490
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add major version upgrade testing from previous versions to mysql_upgrade.test
Previously, only upgrades from 10.0-10.4 dumps were included in the mysql_upgrade.test file. Include dumps from versions 10.5-11.3 as 11.4 is the current LTS and upgrades from more recent versions are arguably more common/important and have a clear need to continually be validated via this MTR.
For the new versions added (10.5,10.6,10.11,11.1,11.2,11.3), they are either prior LTS versions or their difference in schemas is not insignificant and therefore is valuable to be included for test coverage. Certain intermediate versions are omitted in the interest of avoiding bloating the size of the git repository. For versions 10.7,10.8,10.9 and 10.10, the difference in their schemas in comparison to 10.11 are extremely minimal if present at all. Therefore, the inclusion of these dumps are redundant. Testing of these versions will not provide significant additional marginal value. For these same reasons, 11.0 is also not included as there is no major difference between it and 11.1.
As done previously in f67522e, these dumps were generated with an empty root password as to avoid using unix_socket. Furthermore, locks on the log tables were also omitted. Both of these changes were done in order to prevent errors failing the upgrade during the MTR. Help tables are also omitted from the dump file as they do not affect the upgrade and more importantly, for the sake of minimizing the size of the file.
This PR merely fills the apparent gaps of using the existing functionality of loading a dump from a different version of MariaDB to ensure that an upgrade completes successfully.
Suggestions on ways to further extend, improve or augment major version upgrade testing would also be appreciated.
Release Notes
N/A
How can this PR be tested?
Only changes are to mysql_upgrade.test, which passes successfully.
Basing the PR against the correct MariaDB version
PR quality check
All new code of the whole pull request, including one or several files that are either new files or modified ones, are contributed under the BSD-new license. I am contributing on behalf of my employer Amazon Web Services, Inc.