Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add module for use of resolve #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andres-lowrie
Copy link

Firstly let me say thanks for your work on this, it helps a ton!!


I made the use of resolve a little more explicit by including the path module and changing the function call. I also added the __dirname to the path string as I believe this will help new users of nodejs and webpack by letting them know where their files should be placed relative to the config file.

It should also help with the people who want to just copy/paste the config since they may encounter an error if they don't require said path module before using the resolve function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant