Develop/coyote #10

sebastian-j-ibanez · 2025-01-15T17:56:34Z

Changes made

Upgrade to Java 21

Use openjdk:21-jdk-slim Docker image.
Related PR can be found here.

Upgrade to Struts 2

Update all classes related to struts 1 to use struts 2.
Related PR can be found here.

Fix JSP compilation errors

Document the command to compile JSPs in pom (mvn package -Pjspc).
Fix all outstanding JSP compilation errors.
Also cleanup POM dependencies.
Related PR can be found here.

Update insecure pom dependencies

Several dependencies could be upgraded without any breaking changes.
These updates eliminated Dependabot security issues.
Related PR can be found here.

Fix unit test failures

Several small fixes that cause
Related PR can be found here

Updated AllergyDaoImpl.java

- Changed the 0 to 1 on line 90. - Changed the named parameters.

- Changed the 0s to 1s. - Changed named parameters. - Added 1 next to the ?

Update BillingONCHeader1DaoImpl.java - Changed named parameters. - Added missing numbers beside the ?

Reverted BornTransmissionLogDaoImpl.java file

Revert ClinincNbrDaoImpl.java file

Revert ConusltResponseDaoImpl.java

Revert ConsultRequestDaoImpl.java

Revert CVCMedicationGTINDao.java

Update CustomFilterDaoImpl.java

Revert CtlSpecialInstructionsDaoImpl.java

Revert DemographicDao.java

Revert DemographicExtDao.java

Revert DepartmentDaoImpl.java

Revert DocumentResultsDaoImpl.java

Update DocumentDaoImpl.java - changed named parameters - added the missing 1 beside the ?

Update EFormDAtaDaoImpl.java - changed named parameters - added missing numbers beside the ?

Update EChartDaoImpl.java file - changed named parameters - added missing numbers beside the ?

Update EmailConfigDaoImpl.java - changed the named parameters to ?1

Revert EyeformMacroDaoImpl.java

Update EReferAttachmentDataDaoImpl.java - changed the named parameters

Update HI7TextInfoDaoImpl.java file - changed named parameters - added missing numbers beside the ?

… file Revert Hsfo2RecommitScheduleDaoImpl.java

Revert Icd10Dao.java

Revert InstitutionDaoImpl.java

Revert IntegratorControlDaoImpl.java

Update MdsOBRDAoIMpl.java file - changed the line 53

Update MessageLostDaoImpl.java - changed named parameters

Update BedDaoImpl.java - to prevent mismatches between the expected parameter indices and the bound values

Update Rourke2020Dao.java - just the correct named parameter

…ssue-181-update-struts-1

- Updated JDK version number. - Removed `java.security.acl.Group` package, it has been deprecated in Java 9, and removed in Java 14.

…lder

…ecord page

…-plugin

sourcery-ai

The pull request #10 has too many files changed.

We can only review pull requests with up to 300 changed files, and this pull request has 8561.

garciaerin and others added 30 commits December 6, 2024 11:19

fix: correct positional parameters in HQL queries

923dba9

Updated AllergyDaoImpl.java

fix: update HQL queries to use correct positional parameter format

9fcb7b2

- Changed the 0 to 1 on line 90. - Changed the named parameters.

fix: updated the HQL queries to use correct positional parameters format

412089f

- Changed the 0s to 1s. - Changed named parameters. - Added 1 next to the ?

fix: corrected positional parameters format

a16b3dd

Update BillingONCHeader1DaoImpl.java - Changed named parameters. - Added missing numbers beside the ?

fix: reverted the changes in the BornTransmissionLogDaoImpl.java file

2d32cc4

Reverted BornTransmissionLogDaoImpl.java file

fix: reverted the changes in the file ClinincNbrDaoImpl.java file

75170bf

Revert ClinincNbrDaoImpl.java file

fix: reverted the changes in ConusltResponseDaoImpl.java file

acb6e6a

Revert ConusltResponseDaoImpl.java

fix: reverted the changes in ConsultRequestDaoImpl.java file

437dfd8

Revert ConsultRequestDaoImpl.java

fix: reverted the changes in CVCMedicationGTINDao.java file

32c0ade

Revert CVCMedicationGTINDao.java

fix: added a } in line 106 in CustomFIlterDaoIMpl.java file

329b7cd

Update CustomFilterDaoImpl.java

fix: reverted the changes in CtlSpecialInstructionsDaoImpl.java file

7672977

Revert CtlSpecialInstructionsDaoImpl.java

fix: revert the changes in DemographicDao.java file

dfac91f

Revert DemographicDao.java

fix: reverted the changes in DemographicExtDao.java file

87fdd01

Revert DemographicExtDao.java

fix: reverted the changes in the DepartmentDaoImpl.java file

f7d05a6

Revert DepartmentDaoImpl.java

fix: reverted the changes in DocumentResultsDaoImpl.java file

a360379

Revert DocumentResultsDaoImpl.java

fix: updated the HQL queries to use correct positional parameters format

e4ffa42

Update DocumentDaoImpl.java - changed named parameters - added the missing 1 beside the ?

fix: update HQL queries to use correct positional parameters format

67c4af2

Update EFormDAtaDaoImpl.java - changed named parameters - added missing numbers beside the ?

fix: update the HQL queries to use correct positional parameters

5f2ba89

Update EChartDaoImpl.java file - changed named parameters - added missing numbers beside the ?

fix: update HQL queries to use correct positional parameters

9536b91

Update EmailConfigDaoImpl.java - changed the named parameters to ?1

fix revert the changes in the EyeformMacroDaoImpl.java file

6cc0b5b

Revert EyeformMacroDaoImpl.java

fix: update the HQL queries to use correct positional parameters

c655e20

Update EReferAttachmentDataDaoImpl.java - changed the named parameters

fix: update HQL queries to use correct positional parameters format

4174802

Update HI7TextInfoDaoImpl.java file - changed named parameters - added missing numbers beside the ?

fix: revert the changes in the file Hsfo2RecommitScheduleDaoImpl.java…

35a4bfb

… file Revert Hsfo2RecommitScheduleDaoImpl.java

fix: revert the changes in the Icd10Dao.java file

8b0ddb3

Revert Icd10Dao.java

fix: revert the changes in InstitutionDaoImpl.java file

0d51934

Revert InstitutionDaoImpl.java

fix: reverted the changes in the IntegratorControlDaoImpl.java file

84a91e4

Revert IntegratorControlDaoImpl.java

fix: update HQL queries to use correct positional parameter format

cb73b8b

Update MdsOBRDAoIMpl.java file - changed the line 53

fix: update HQL queries to use correct positional parameters

e9291a0

Update MessageLostDaoImpl.java - changed named parameters

fix: corrected the positional parameters

c4e9c1c

Update BedDaoImpl.java - to prevent mismatches between the expected parameter indices and the bound values

fix: update HQL query to use correct positional parameter format

4013dc6

Update Rourke2020Dao.java - just the correct named parameter

gongjian1981 and others added 28 commits January 8, 2025 13:34

fix: fix JSP compile issues

1b36937

fix: fix 404 error

3318fa8

fix: use parameter to make dynamic action

dbe3ee7

Merge branch 'develop/bullfrog' of github.com:cc-ar-emr/Open-O into i…

5aa301b

…ssue-181-update-struts-1

feat: setup over ride config properties in make file

256e92f

feat: add help command to make file

c0276c4

chore: refer to project as openosp

a817c61

Merge pull request #47 from cc-ar-emr/issue-181-update-struts-1

a83f999

update: upgraded JDK version from 11 to 17

bf8e27d

- Updated JDK version number. - Removed `java.security.acl.Group` package, it has been deprecated in Java 9, and removed in Java 14.

Merge pull request #49 from cc-ar-emr/issue-48-make-properties-file

a27f2b8

fix: added opens to bypass the security restrictions in Java 17

b65df75

Merge pull request #53 from cc-ar-emr/issue-50-make-help

49d550d

update: upgraded JDK version from 17 to 21

56b737f

Merge pull request #54 from cc-ar-emr/issue-48-make-properties-file

dac693f

fix: use apache.commons.lang3 stringbuilder and reflectiontostringbui…

37abad9

…lder

Merge pull request #45 from cc-ar-emr/java17-upg

14c920d

fix: remove double ;;

26ff290

update: target java 21 in maven compiler plugin

d155fba

Merge pull request #63 from cc-ar-emr/lang3-fixes

fccd617

fix: fixed the 500 error, and css / js issues on Demographic Master R…

e16cd16

…ecord page

fix: fixed the 500 error on Rx page

0416078

fix: fixed jsp compilation errors

1864082

fix: jsp error in ChartNotes and Surveillance

73229db

Merge pull request #64 from cc-ar-emr/jsp-css-fix

99ef1cd

Merge pull request #73 from cc-ar-emr/cleanup-pom-security

e8aef79

fix: import DemographicManager class in efmformslistadd.jsp

38ba8fc

chore: update dependency lock

0a0379c

fix: remove duplicate pom entries for jsoup and dependency-lock-maven…

783350a

…-plugin

sourcery-ai bot reviewed Jan 15, 2025

View reviewed changes

lacarmen merged commit a7dae07 into MagentaHealth:develop/coyote Jan 15, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Develop/coyote #10

Develop/coyote #10

sebastian-j-ibanez commented Jan 15, 2025

sourcery-ai bot left a comment

Develop/coyote #10

Develop/coyote #10

Conversation

sebastian-j-ibanez commented Jan 15, 2025

Changes made

Upgrade to Java 21

Upgrade to Struts 2

Fix JSP compilation errors

Update insecure pom dependencies

Fix unit test failures

sourcery-ai bot left a comment

Choose a reason for hiding this comment