Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove build hacks that are no longer needed #599

Closed

Conversation

henryleberre
Copy link
Member

@henryleberre henryleberre commented Aug 31, 2024

  • Removed CCE 16 workgroup hacks.
  • Removed Silo patch for HDF5 on Frontier.
  • Removed AppleClang workarounds on macOS, including building MPI from scratch.
  • Only build HDF5, FFTW, and SILO packages if they are not installed/compatible.
  • Removed Docker (nobody uses it, and maintaining it is cumbersome).
  • Switched to using the proper Silo patch for an error on GNU 13 and above. See my comment here: Silo does not compile with gcc 14 LLNL/Silo#375 (comment).
  • Removed installation instructions for Arch Linux. They installed their operating system, I'm sure they can install gcc.
  • Removed our FindHDF5 file. We can use the built-in.

README.md Show resolved Hide resolved
Copy link

codecov bot commented Aug 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.99%. Comparing base (cf3ac9f) to head (daef835).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #599      +/-   ##
==========================================
+ Coverage   53.28%   53.99%   +0.70%     
==========================================
  Files          58       58              
  Lines       14150    13719     -431     
  Branches     1729     1635      -94     
==========================================
- Hits         7540     7407     -133     
+ Misses       6097     5867     -230     
+ Partials      513      445      -68     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henryleberre henryleberre force-pushed the chemfc-up-and-down branch 2 times, most recently from 2f88343 to daef835 Compare September 1, 2024 02:20
@sbryngelson
Copy link
Member

[TODO] Check FOM is roughly the same w/o workaround for workgroup size on CCE18.

@sbryngelson sbryngelson linked an issue Sep 1, 2024 that may be closed by this pull request
@henryleberre henryleberre mentioned this pull request Sep 3, 2024
1 task
@sbryngelson
Copy link
Member

sbryngelson commented Sep 3, 2024

  • Removed installation instructions for Arch Linux. They installed their operating system, I'm sure they can install gcc.

🤣 🤣 🤣
You might still leave them a list of packages they need. MFC's dependencies are not obvious other than from our installation instructions.

@henryleberre
Copy link
Member Author

  • Removed installation instructions for Arch Linux. They installed their operating system, I'm sure they can install gcc.

🤣 🤣 🤣 You might still leave them a list of packages they need. MFC's dependencies are not obvious other than from our installation instructions.

The assumption is that they can look at those needed on Debian as reference. The only one that isn't obvious is gcc-fortran but solving that is one error and a google search.

@henryleberre henryleberre force-pushed the chemfc-up-and-down branch 9 times, most recently from bdb8491 to aba6f9d Compare September 9, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Don't need CCE16 workaround anymore
2 participants