Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change optimize.minimize method from SLSQP to Nelder-Mead #455

Merged

Conversation

veni-vidi-vici-dormivi
Copy link
Collaborator

@veni-vidi-vici-dormivi veni-vidi-vici-dormivi commented May 23, 2024

Changing the method in optimize.minimize` to Nelder-Mead from SLSQP should make the coefficients fit more stable, see #440 (comment)

Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.19%. Comparing base (9b0b76b) to head (ff8f733).
Report is 84 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (9b0b76b) and HEAD (ff8f733). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (9b0b76b) HEAD (ff8f733)
unittests 3 1
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #455      +/-   ##
==========================================
- Coverage   87.90%   82.19%   -5.72%     
==========================================
  Files          40       43       +3     
  Lines        1745     1938     +193     
==========================================
+ Hits         1534     1593      +59     
- Misses        211      345     +134     
Flag Coverage Δ
unittests 82.19% <ø> (-5.72%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@veni-vidi-vici-dormivi veni-vidi-vici-dormivi merged commit 91730c6 into MESMER-group:main May 23, 2024
9 checks passed
@veni-vidi-vici-dormivi veni-vidi-vici-dormivi deleted the pt_method branch May 23, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants