Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor Gaspari Cohn to accelerate it #393

Conversation

veni-vidi-vici-dormivi
Copy link
Collaborator

Closes #157

Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9b0b76b) 87.90% compared to head (ee18751) 87.90%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #393   +/-   ##
=======================================
  Coverage   87.90%   87.90%           
=======================================
  Files          40       40           
  Lines        1745     1745           
=======================================
  Hits         1534     1534           
  Misses        211      211           
Flag Coverage Δ
unittests 87.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@veni-vidi-vici-dormivi
Copy link
Collaborator Author

Not sure what to do about the linting here @mathause...

@mathause
Copy link
Member

mathause commented Feb 9, 2024

Yes this is ugly 😞 How about:

  • remove # fmt: off
  • call black --line-length 200 mesmer/stats/_gaspari_cohn.py
  • add # fmt: off & # fmt: on around the two lines

Can you add a # NOTE: see https://github.com/MESMER-group/mesmer/issues/157 comment?

@veni-vidi-vici-dormivi veni-vidi-vici-dormivi merged commit 0df7211 into MESMER-group:main Feb 9, 2024
7 checks passed
@veni-vidi-vici-dormivi veni-vidi-vici-dormivi deleted the gc_acceleration branch February 9, 2024 16:38
@mathause
Copy link
Member

mathause commented Feb 9, 2024

Thanks 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

speed up gaspari cohn
2 participants