Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LoadCodecs.cpp #562

Closed
wants to merge 1 commit into from
Closed

Update LoadCodecs.cpp #562

wants to merge 1 commit into from

Conversation

modz2014
Copy link

@modz2014 modz2014 commented Feb 4, 2025

Updated plugin loading to allow Formats and Codecs to be loaded from a writable location instead of the read-only WindowsApps folder used by MSIX installations. This enables users to add or update plugins without modifying the package

Changed plugin loading to allow Formats and Codecs to be loaded from a writable location instead of the WindowsApps folder.
@modz2014 modz2014 mentioned this pull request Feb 4, 2025
@MouriNaruto
Copy link
Member

Currently, NanaZip doesn't accept any plugin-related PRs because many design issues need to be considered first.

Kenji Mouri

@MouriNaruto MouriNaruto closed this Feb 4, 2025
@MouriNaruto
Copy link
Member

But we always welcome to merge builtin codec PRs if it's decoupled from 7-Zip mainline's source code definitions a.k.a. uses https://github.com/M2Team/NanaZip/blob/main/NanaZip.Specification/NanaZip.Specification.SevenZip.h.

Kenji Mouri

@MouriNaruto
Copy link
Member

Read #563 for more information.

Kenji Mouri

@modz2014
Copy link
Author

modz2014 commented Feb 4, 2025

@MouriNaruto Just to clarify, my pull request only involves changing the location where the plugins are loaded, and does not introduce any new plugin functionality or code. It’s focused solely on adjusting the loading mechanism without altering how the plugins themselves work.

@MouriNaruto
Copy link
Member

It’s focused solely on adjusting the loading mechanism without altering how the plugins themselves work.

We need to care about that. So, actually, we need a new plugin model.

Kenji Mouri

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants