Merge pull request #416 from Lombiq/issue/INFRA-164

INFRA-164: GHA/WarpBuild runner OS version pinning

Lombiq.Tests.UI/Docs/SecurityScanning.md

@@ -33,7 +33,7 @@ This is because the Docker installation is configured to use Windows images, whi
     # See https://github.com/Lombiq/GitHub-Actions/blob/dev/.github/workflows/build-and-test-orchard-core.yml.
     uses: Lombiq/GitHub-Actions/.github/workflows/build-and-test-orchard-core.yml@dev
     with:
-      machine-types: '["windows-latest"]'
+      machine-types: '["windows-2022"]'
       test-filter: "FullyQualifiedName!~SecurityScanningTests"
 ```
 

Lombiq.Tests.UI/Services/WebDriverFactory.cs

@@ -25,9 +25,6 @@ public static Task<Func<ChromeDriver>> CreateChromeDriverAsync(BrowserConfigurat
         Task<Func<ChromeDriver>> CreateDriverInnerAsync(string driverPath = null) =>
             Task.FromResult(() =>
             {
-                // Note that no-sandbox should NOT be used, because it causes Chrome processes to remain open, see
-                // https://github.com/Lombiq/UI-Testing-Toolbox/issues/356.
-
                 var chromeConfig = new ChromeConfiguration { Options = new ChromeOptions().SetCommonOptions() };
 
                 chromeConfig.Options.SetLoggingPreference(LogType.Browser, LogLevel.Info);
@@ -160,6 +157,12 @@ private static TDriverOptions SetCommonChromiumOptions<TDriverOptions>(
         // Disabling smooth scrolling to avoid large waiting time when taking full-page screenshots.
         options.AddArgument("disable-smooth-scrolling");
 
+        // Previously this switch caused Chrome processes to remain open after test execution, see
+        // https://github.com/Lombiq/UI-Testing-Toolbox/issues/356, but it doesn't seem to be case anymore.
+        // Additionally, Ubuntu 2024-based GitHub Actions runners seem to require this flag to be set, see
+        // https://github.com/actions/runner-images/issues/8268#issuecomment-2343831000.
+        options.AddArgument("--no-sandbox");
+
         if (configuration.FakeVideoSource is not null)
         {
             var fakeCameraSourceFilePath = configuration.FakeVideoSource.SaveVideoToTempFolder();