ensure connections are closed

LiquidPlanner · May 14, 2015 · fcb697c · fcb697c
1 parent fbd78b2
commit fcb697c
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 9 deletions.
diff --git a/c#.net/LiquidPlanner/LiquidPlanner/Program.cs b/c#.net/LiquidPlanner/LiquidPlanner/Program.cs
@@ -89,7 +89,6 @@ public LiquidPlanner(string username, string password)
         private LpResponse request(String verb, String url, Object data)
         {
             HttpWebRequest request;
-            WebResponse response;
             String      uri;
             LpResponse  lp_response;
 
@@ -113,9 +112,12 @@ private LpResponse request(String verb, String url, Object data)
             lp_response = new LpResponse();
             try
             {
-                response = request.GetResponse();
-                StreamReader reader = new StreamReader(response.GetResponseStream());
-                lp_response.response = reader.ReadToEnd();
+                using (response = request.GetResponse()) 
+                {
+                  using (StreamReader reader = new StreamReader(response.GetResponseStream())) {
+                    lp_response.response = reader.ReadToEnd();
+                  }
+                }
             }
             catch (Exception e)
             {

diff --git a/vb.net/LiquidPlannerVB/LiquidPlanner.vb b/vb.net/LiquidPlannerVB/LiquidPlanner.vb
@@ -74,7 +74,6 @@ Module LiquidPlanner
 
         Private Function request(ByVal verb As String, ByVal url As String, ByRef data As Object) As LpResponse
             Dim theRequest As HttpWebRequest
-            Dim response As WebResponse
             Dim uri As String
             Dim lp_response As LpResponse
 
@@ -95,9 +94,11 @@ Module LiquidPlanner
 
             lp_response = New LpResponse()
             Try
-                response = theRequest.GetResponse
-                Dim reader As StreamReader = New StreamReader(response.GetResponseStream)
-                lp_response.response = reader.ReadToEnd
+                Using response = theRequest.GetResponse
+                  Using reader As StreamReader = New StreamReader(response.GetResponseStream)
+                    lp_response.response = reader.ReadToEnd
+                  End Using
+                End Using
             Catch ex As Exception
                 lp_response.anError = ex
             End Try
@@ -189,4 +190,4 @@ Module LiquidPlanner
         aTask = liquidplanner.UpdateTask(aTask)
     End Sub
 
-End Module
+End Module