[pull] master from cmangos:master #43
Open
+754,214
−892,418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
killerwife
force-pushed
the
master
branch
3 times, most recently
from
d794e29 to
b85aea8
Compare
killerwife
force-pushed
the
master
branch
3 times, most recently
from
b453f29 to
8522113
Compare
killerwife
force-pushed
the
master
branch
2 times, most recently
from
ba1adca to
6cd60c5
Compare
killerwife
force-pushed
the
master
branch
2 times, most recently
from
7806a67 to
d0cc28c
Compare
killerwife
force-pushed
the
master
branch
2 times, most recently
from
bb2815b to
4ce90bc
Compare
killerwife
force-pushed
the
master
branch
2 times, most recently
from
653dbce to
82eb575
Compare
killerwife
force-pushed
the
master
branch
2 times, most recently
from
83bbe1f to
46d21e6
Compare
This makes sure the AuthSocket member function pointer member gets properly aligned by the compiler. Packing this struct is not really needed because this struct isn't part of the client-server protocol.
…many players being able to join.
…correct target if possible
…MOVE_DYNAMIC fixeddist
Loot objects have ownership of their LootItem objects, and also keep track of any associated GroupLootRoll objects. A GroupLootRoll object in turn references the LootItem the roll is about, and its destructor may still use the LootItem. So when a Loot object is destructed, it can't delete its LootItem objects as long as any GroupLootRoll objects are still around that may reference/use them! Fixes cmangos/issues#3860.
Just a fair warning, a lot of things might go wrong here. That being said, this is supported by evidence. The temporary GOs never create type 11 so only here a change is needed
This reverts commit 124115d. Reverting until i find fix. Still correct change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )