Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compile_fn parameter for Trainer #20269

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mieshkiwrk
Copy link

@mieshkiwrk mieshkiwrk commented Sep 10, 2024

Add support for compile_fn for Trainer for example to compile model after applying strategy

Example usage: needed to compile after applying DDP strategy to get pre/post forward also compiled

Fixes #20242


📚 Documentation preview 📚: https://pytorch-lightning--20269.org.readthedocs.build/en/20269/

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 10, 2024
@mieshkiwrk
Copy link
Author

Both benchmarks checks failed due to timeout

@mieshkiwrk
Copy link
Author

bump

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 81%. Comparing base (5be58f6) to head (4648ea2).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (5be58f6) and HEAD (4648ea2). Click for more details.

HEAD has 553 uploads less than BASE
Flag BASE (5be58f6) HEAD (4648ea2)
cpu 147 21
lightning 106 16
pytest 87 2
python3.9 43 6
python3.10 42 6
lightning_fabric 25 0
gpu 4 2
python3.11 42 6
python3.12 20 3
pytorch2.1 38 12
pytest-full 64 21
pytorch2.3 9 3
pytorch_lightning 20 7
pytorch2.2 9 3
pytorch2.4 8 3
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #20269     +/-   ##
=========================================
- Coverage      89%      81%     -8%     
=========================================
  Files         267      264      -3     
  Lines       23084    23032     -52     
=========================================
- Hits        20585    18620   -1965     
- Misses       2499     4412   +1913     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pl Generic label for PyTorch Lightning package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add something like use_compile parameter for Trainer
1 participant