Changes related to issue #4 (LG G2 Sprint, LS980) #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
| end | ||
| -- if not ((endpoint == 0x85 or endpoint == 3) and transfer_type == 3) then | ||
| -- return 0 | ||
| -- end |
There was a problem hiding this comment.
Yes this is unfortunate, I had to do the same to test your capture (actually, the bulk transfer type check can stay).
Maybe I have to detect this earlier or turn it into a pref (or drop the EP number check).
Lekensteyn
changed the title
|
The device name needs to be probed apparently to work on older devices. The overflow detection and close/open/read fallback is too ugly to get in ;-) I'll keep it open in case other users encounter similar issues. |
|
This patch was needed for my friend to download a 4.5GB partition from their LG G4 H810. Without it, it timed out around the ~500MB mark. |
|
Closing in favor of #60 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles the overflow error in #4 and also a timeout error I came across.
You probably don't want to merge these commits as-is, I don't think they're portable.