Tests/LibWeb: Finish async test when an error is caught #3270
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmg-x
force-pushed
the
catch-async-errors
branch
2 times, most recently
from
0bd2db2 to
3a7e2d4
Compare
This catches errors that occur within async tests so that we fail faster rather than timing out due to `done()` not being called. We use `Promise.resolve()` because `f` isn't guaranteed to be an async function.
rmg-x
force-pushed
the
catch-async-errors
branch
from
3a7e2d4 to
b2c4b15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This catches errors that occur within async tests so that we fail faster
rather than timing out due to
done()not being called.We use
Promise.resolve()becausefisn't guaranteed to be an asyncfunction.