LibWeb: Fix context menu and select dropdown position in iframe #3249
+7
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! One or more of the commit messages in this PR do not match the Ladybird code submission policy, please check the |
Psychpsyo
force-pushed
the
fix-iframe-context-menu
branch
from
45b434b to
ba06526
Compare
Psychpsyo
changed the title
Psychpsyo
force-pushed
the
fix-iframe-context-menu
branch
from
ba06526 to
4c71f65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When right-clicking or interacting with <select> elements inside of iframes, the position of the popup used to be too far up and to the right.
This fixes that.
I've also added a fixme since iframes with CSS transforms applied are still not accounted for.