register parameters with service container #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, parameters aren't actually set unless the user specifies them when registering the provider. Any code that then tries to access these, ends up throwing exceptions. Moving them to register ensures all required parameters are created after the provider is registered. Right now, trying to set values will fail if 'memcache.default_compress' hasn't been set. Same with any of the other parameters. @SimpleWrapper:29 $compress = $this->app['memcache.default_compress'];
|
Can you fix unit tests ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, parameters aren't actually set unless the user specifies them when registering the provider. Any code that then tries to access these, ends up throwing exceptions. Moving them to register ensures all required parameters are created after the provider is registered.
Right now, trying to set values will fail if 'memcache.default_compress' hasn't been set. Same with any of the other parameters.
@SimpleWrapper:29
$compress = $this->app['memcache.default_compress'];