-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce spotless/ktlint #39
base: main
Are you sure you want to change the base?
Conversation
But we may need to write a Gradle task to download the latest compose rules ktlint jar from https://github.com/mrmans0n/compose-rules/releases during project synchronization and import it into the project, so that the Ktlint IDEA plugin can import lint suggestions related to compose? |
...gallery/src/commonMain/kotlin/org/jetbrains/compose/storytale/gallery/story/StoryListItem.kt
Outdated
Show resolved
Hide resolved
Hi @whitescent ! |
.editorconfig
Outdated
|
||
[*] | ||
charset = utf-8 | ||
indent_size = 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use 4 spaces, as suggested by the official convention - https://kotlinlang.org/docs/coding-conventions.html#indentation ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! but for the compose project, I might prefer 2 spaces for indentation, as it looks more readable in cases with deep component nesting. However, if 4 spaces are to be used, that's fine too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it.
One more argument for keeping it 4 is that the repository is in Kotlin group, so using the official convention is preferred :)
#37 #36