Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(router): remove duplicated reload_router() #13693

Merged
merged 9 commits into from
Sep 27, 2024

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Sep 19, 2024

Summary

KAG-5423

Separate setenv/unsetenv from misc to sys, then they will not depend on intenal.constants.

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

@github-actions github-actions bot added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Sep 19, 2024
@pull-request-size pull-request-size bot added size/L and removed size/M labels Sep 19, 2024
@chronolaw chronolaw marked this pull request as ready for review September 19, 2024 07:49
@team-gateway-bot team-gateway-bot added the author/community PRs from the open-source community (not Kong Inc) label Sep 19, 2024
@chronolaw chronolaw removed the author/community PRs from the open-source community (not Kong Inc) label Sep 19, 2024
@team-gateway-bot team-gateway-bot added the author/community PRs from the open-source community (not Kong Inc) label Sep 19, 2024
spec/internal/module.lua Show resolved Hide resolved
@ms2008 ms2008 merged commit b64b6fb into master Sep 27, 2024
25 checks passed
@ms2008 ms2008 deleted the tests/rework_reload_router branch September 27, 2024 08:42
@team-gateway-bot
Copy link
Collaborator

Cherry-pick failed for master, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13693-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13693-to-master-to-upstream
git checkout -b cherry-pick-13693-to-master-to-upstream
ancref=$(git merge-base a6ccbb1af2169a9edbf4491a91ecaf5d2d7fb067 c8cf5b703ebe4fe8ae785a8ae3dbf8af95034025)
git cherry-pick -x $ancref..c8cf5b703ebe4fe8ae785a8ae3dbf8af95034025

@github-actions github-actions bot added the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Sep 27, 2024
@kikito kikito removed the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author/community PRs from the open-source community (not Kong Inc) cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee size/L skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants