-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests(router): remove duplicated reload_router()
#13693
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
cherry-pick kong-ee
schedule this PR for cherry-picking to kong/kong-ee
label
Sep 19, 2024
team-gateway-bot
added
the
author/community
PRs from the open-source community (not Kong Inc)
label
Sep 19, 2024
chronolaw
removed
the
author/community
PRs from the open-source community (not Kong Inc)
label
Sep 19, 2024
team-gateway-bot
added
the
author/community
PRs from the open-source community (not Kong Inc)
label
Sep 19, 2024
chronolaw
force-pushed
the
tests/rework_reload_router
branch
from
September 20, 2024 06:34
df55637
to
64517e4
Compare
chronolaw
force-pushed
the
tests/rework_reload_router
branch
from
September 27, 2024 02:34
64517e4
to
3a7850f
Compare
ms2008
approved these changes
Sep 27, 2024
Water-Melon
approved these changes
Sep 27, 2024
Cherry-pick failed for Please cherry-pick the changes locally. git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13693-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13693-to-master-to-upstream
git checkout -b cherry-pick-13693-to-master-to-upstream
ancref=$(git merge-base a6ccbb1af2169a9edbf4491a91ecaf5d2d7fb067 c8cf5b703ebe4fe8ae785a8ae3dbf8af95034025)
git cherry-pick -x $ancref..c8cf5b703ebe4fe8ae785a8ae3dbf8af95034025 |
github-actions
bot
added
the
incomplete-cherry-pick
A cherry-pick was incomplete and needs manual intervention
label
Sep 27, 2024
kikito
removed
the
incomplete-cherry-pick
A cherry-pick was incomplete and needs manual intervention
label
Oct 15, 2024
curiositycasualty
pushed a commit
that referenced
this pull request
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author/community
PRs from the open-source community (not Kong Inc)
cherry-pick kong-ee
schedule this PR for cherry-picking to kong/kong-ee
size/L
skip-changelog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
KAG-5423
Separate
setenv/unsetenv
from misc to sys, then they will not depend onintenal.constants
.Checklist
changelog/unreleased/kong
orskip-changelog
label added on PR if changelog is unnecessary. README.mdIssue reference
Fix #[issue number]