fix(core): node_id in configuration is deprecated in this PR
#13687
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core/pdk
cherry-pick kong-ee
liverpool8056
added
the
pr/ready (but hold merge)
team-gateway-bot
added
the
author/community
means it is not recommended to be specified manually. A warning message is printed in the error log if the `node_id` is recognized in the configuration. FTI-6221
liverpool8056
force-pushed
the
deprecate_node_id
branch
from
e680790
to
33f043e
Compare
teb510
reviewed
Sep 18, 2024
kong/pdk/node.lua
Outdated
| @@ -272,6 +272,9 @@ local function new(self) | |||
| -- 1. user provided node id | |||
| local configuration_node_id = self and self.configuration and self.configuration.node_id | |||
| if configuration_node_id then | |||
| ngx.log(ngx.WARN, "The `node_id`, which has been deprecated since 3.9, is not recommended to be specified manually!!!\n", | |||
There was a problem hiding this comment.
how about:
manually specifying a node_id is deprecated as of 3.9, it is not recommended to be specified manually. please make sure it is unique across the cluster. Please note that it will be removed in 4.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
node_idin configuration is deprecated in this PR, which means it is not recommended to be specified manually.A warning message is printed in error log if the
node_idis recognized in the configuration.Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
FTI-6221