Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pdk/vault): handle crud events for dbless #13663

Merged
merged 3 commits into from
Sep 20, 2024

Conversation

chronolaw
Copy link
Contributor

Summary

KAG-5371

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

@github-actions github-actions bot added core/pdk cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Sep 13, 2024
@chronolaw chronolaw requested a review from dndx September 13, 2024 02:33
@team-gateway-bot team-gateway-bot added the author/community PRs from the open-source community (not Kong Inc) label Sep 16, 2024
@bungle
Copy link
Member

bungle commented Sep 18, 2024

So the plan is to register these event handlers even when we don't use incremental sync (dbless nodes, or data plane nodes using old full sync)? Probably causes a bit of memory usage at least. We don't want to add flag or something?

@chronolaw chronolaw marked this pull request as draft September 18, 2024 08:43
@chronolaw chronolaw marked this pull request as ready for review September 18, 2024 09:24
@chronolaw chronolaw removed the author/community PRs from the open-source community (not Kong Inc) label Sep 18, 2024
@team-gateway-bot team-gateway-bot added the author/community PRs from the open-source community (not Kong Inc) label Sep 18, 2024
@chronolaw chronolaw removed the author/community PRs from the open-source community (not Kong Inc) label Sep 19, 2024
@team-gateway-bot team-gateway-bot added the author/community PRs from the open-source community (not Kong Inc) label Sep 19, 2024
@chronolaw chronolaw merged commit 4af5287 into feat/incremental Sep 20, 2024
34 of 42 checks passed
@chronolaw chronolaw deleted the fix/handle_crud_events branch September 20, 2024 10:33
chronolaw added a commit that referenced this pull request Sep 20, 2024
* fix(pdk/vault): handle crud events for dbless

* check cluster_rpc

* fix mistake
chronolaw added a commit that referenced this pull request Oct 12, 2024
* fix(pdk/vault): handle crud events for dbless

* check cluster_rpc

* fix mistake
dndx pushed a commit that referenced this pull request Oct 16, 2024
* fix(pdk/vault): handle crud events for dbless

* check cluster_rpc

* fix mistake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author/community PRs from the open-source community (not Kong Inc) cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/pdk size/XS skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants