fix(opentelemetry): tostring header_type avoid concatenation nil error in log
#13612
+32
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ror in log (#10137) The require of header_type is false, so the consumer can choose `header_type` to be nil in Kong Manager; if this is, Kong Manager would pass `json.null` to Kong, `header_type` could be nil in this case. This PR respects this behavior and handles concatenation nil error when `header_type` is nil. Note that this is a fix that only exists in the 3.4 series. Fix: [FTI-6119](https://konghq.atlassian.net/browse/FTI-6119) Signed-off-by: tzssangglass <[email protected]>
github-actions
bot
added
core/tracing
core/wasm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of the https://github.com/Kong/kong-ee/pull/10137
Summary
The require of header_type is false, so the consumer can choose
header_typeto be nil in Kong Manager; if this is, Kong Manager would passjson.nullto Kong,header_typecould be nil in this case.This PR respects this behavior and handles concatenation nil error when
header_typeis nil.Checklist
CHANGELOG/unreleased/kongor addingskip-changeloglabel on PR if unnecessary. README.mdIssue reference
Fix: FTI-6119