Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PointPicker: PointId would be overwritten with multiple actors. #3173

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

yarous224
Copy link
Contributor

Context

When using multiple actors with PointPicker, the pointID is overwritten by the latter actor, regardless of whether it finds a point. I referred to VTK C++ to modify this part.

Results

Changes

  • Documentation and TypeScript definitions were updated to match those changes

PR and Code Checklist

  • semantic-release commit messages
  • Run npm run reformat to have correctly formatted code

Testing

  • This change adds or fixes unit tests
  • Tested environment:
    • vtk.js:
    • OS:
    • Browser:

Copy link
Collaborator

@floryst floryst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on the C++ implementation.

@floryst floryst added this pull request to the merge queue Nov 11, 2024
Merged via the queue into Kitware:master with commit 18d3a94 Nov 11, 2024
3 checks passed
Copy link

🎉 This PR is included in version 32.6.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Automated label label Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Automated label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants