Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vtkGCodeReader): add vtkGCodeReader #3150

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

daker
Copy link
Collaborator

@daker daker commented Oct 20, 2024

Context

This PR adds support for G-Code format
Fixes #3149

Results

Enregistrement.de.l.ecran.2024-10-20.173226.mp4

Changes

  • Documentation and TypeScript definitions were updated to match those changes

PR and Code Checklist

  • semantic-release commit messages
  • Run npm run reformat to have correctly formatted code

Testing

  • This change adds or fixes unit tests
  • Tested environment:
    • vtk.js:
    • OS:
    • Browser:

@daker daker force-pushed the add-gcodereader branch 2 times, most recently from b7ffc26 to b733381 Compare October 21, 2024 14:26
@jourdain
Copy link
Collaborator

@floryst @finetjul any other PR ready to merge that we want to bundle that one with?

@floryst floryst added this pull request to the merge queue Oct 21, 2024
Merged via the queue into Kitware:master with commit c7971eb Oct 21, 2024
3 checks passed
Copy link

🎉 This PR is included in version 32.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Automated label label Oct 21, 2024
@daker daker deleted the add-gcodereader branch October 21, 2024 21:17
@finetjul
Copy link
Member

Instead of having multiple polydatas as output of your reader, you should have a unique polydatas output, but for each cell, you associate a layer scalar value into a cell data array.
For rendering, you can filter the polydatas based on the cell data array. For coloring you apply a unique look up table with a color per layer value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Automated label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Support for G-Code format
4 participants