Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(HDRReader): add vtkHDRReader #3146

Merged
merged 1 commit into from
Oct 21, 2024
Merged

feat(HDRReader): add vtkHDRReader #3146

merged 1 commit into from
Oct 21, 2024

Conversation

daker
Copy link
Collaborator

@daker daker commented Oct 14, 2024 •
edited
Loading

Context

This PR adds support for loading Radiance HDR (RGBE) image format for environment maps

Fixes #3145

Results

image

Changes

  • Documentation and TypeScript definitions were updated to match those changes

PR and Code Checklist

  • semantic-release commit messages
  • Run npm run reformat to have correctly formatted code

Testing

  • This change adds or fixes unit tests
  • Tested environment:
    • vtk.js:
    • OS:
    • Browser:

finetjul
finetjul reviewed Oct 14, 2024
View reviewed changes
Sources/IO/Image/HDRReader/Utils.js Outdated Show resolved Hide resolved
Sources/IO/Image/HDRReader/example/index.js Show resolved Hide resolved
Sources/IO/Image/HDRReader/index.js Show resolved Hide resolved
Sources/IO/Image/HDRReader/index.js Outdated Show resolved Hide resolved
Sources/IO/Image/HDRReader/index.js Outdated Show resolved Hide resolved
Sources/IO/Image/HDRReader/index.js Outdated Show resolved Hide resolved
Sources/IO/Image/HDRReader/index.js Outdated Show resolved Hide resolved
Sources/IO/Image/HDRReader/index.js Show resolved Hide resolved
@daker daker force-pushed the hdr-reader branch 2 times, most recently from 0b1ad5e to 894b938 Compare October 15, 2024 08:58
finetjul
finetjul requested changes Oct 15, 2024
View reviewed changes
Sources/IO/Image/HDRReader/Utils.js Outdated Show resolved Hide resolved
Sources/IO/Image/HDRReader/index.js Outdated Show resolved Hide resolved
@daker daker requested a review from finetjul October 15, 2024 15:46
finetjul
finetjul approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@finetjul finetjul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daker daker force-pushed the hdr-reader branch 2 times, most recently from e413d3d to 093ff92 Compare October 21, 2024 14:32
@floryst floryst added this pull request to the merge queue Oct 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Oct 21, 2024
@floryst floryst added this pull request to the merge queue Oct 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Oct 21, 2024
@daker
Copy link
Collaborator Author

daker commented Oct 21, 2024

@floryst i rebased the branch

@floryst
Copy link
Collaborator

floryst commented Oct 21, 2024

Thanks!

@floryst floryst added this pull request to the merge queue Oct 21, 2024
Merged via the queue into Kitware:master with commit 603d6f9 Oct 21, 2024
3 checks passed
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 32.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Automated label label Oct 21, 2024
@daker daker deleted the hdr-reader branch October 21, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@finetjul finetjul finetjul approved these changes

Assignees
No one assigned
Labels
released Automated label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Support for HDR images
3 participants
@daker @floryst @finetjul