Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix static vtkMapper coincident topology functions #3143

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

PaulHax
Copy link
Collaborator

@PaulHax PaulHax commented Oct 7, 2024

When calling the static mapper vtkMapper.setResolveCoincidentTopologyPolygonOffsetParameters, there is an error because the "class" does not have a publicAPI with a modified() function. publicAPI.modifed() is called by macros.js object setter macro.

Results

Does not error now when calling vtkMapper.setResolveCoincidentTopologyPolygonOffsetParameters.

Changes

The error fix involved adding a noOp modified function. Alternatives could be to check if publicAPI has modified in macros.js or upgrade the Mapper static object with macros.js' function obj(publicAPI = {}, model = {}) "constructor."

PR and Code Checklist

  • semantic-release commit messages
  • Run npm run reformat to have correctly formatted code

Testing

  • This change adds or fixes unit tests
  • Tested environment:
    • vtk.js:
    • OS:
    • Browser:

because publicAPI.modifed is called by macros.js object setter macro.

Avoid error calling functions like vtkMapper.setResolveCoincidentTopologyPolygonOffsetParameters
Copy link
Member

@finetjul finetjul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@floryst floryst added this pull request to the merge queue Oct 8, 2024
Merged via the queue into Kitware:master with commit 4691eea Oct 8, 2024
3 checks passed
Copy link

github-actions bot commented Oct 8, 2024

🎉 This PR is included in version 32.3.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Automated label label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Automated label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Tests for static vtkMapper Coincident Topology API
3 participants