Fix static vtkMapper coincident topology functions #3143
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling the static mapper
vtkMapper.setResolveCoincidentTopologyPolygonOffsetParameters
, there is an error because the "class" does not have a publicAPI with amodified()
function.publicAPI.modifed()
is called by macros.js object setter macro.Results
Does not error now when calling
vtkMapper.setResolveCoincidentTopologyPolygonOffsetParameters
.Changes
The error fix involved adding a noOp
modified
function. Alternatives could be to check ifpublicAPI
hasmodified
in macros.js or upgrade the Mapper static object with macros.js'function obj(publicAPI = {}, model = {})
"constructor."PR and Code Checklist
npm run reformat
to have correctly formatted codeTesting