Multi volume #3133
Draft
Multi volume #3133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These functions used a `getInput` method that doesn't exist It is not a breaking change as these functions instantly crash when called
The ImageSlice actor already used a more concise code. Do the same for the base Actor and and Volume actor.
The prop3D has three children that were redefining `getBounds` in the same way. Move the definition of `getBounds` in the prop3D. Update typescript accordingly.
BREAKING CHANGE: Move vtkVolumeMapper's properties related to rendering in vtkVolumeProperty. Add a clear error message for these widely used methods. This is part of the MultiVolumeMapper feature.
This work is part of the MultiVolumeMapper feature Fix the getVolumes function which didn't return an array
Instead of comparing a big state that take all actor properties into account, compare the mtime of the actor as it takes properties into account
Support multiple images as input Shader compilation is too long Even longer on Windows + NVidia Use clang-reformat for a uniform styling of shader
|
It is to be noted that #3132 has various fixes that are not in 3133. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for multi volume.
It is not intended to be merged, as the shader takes too much time to compile on some systems (e.g. Windows + NVidia + Chrome).
It gives an overview of how it can be done one wants to add multi volume support to vtk.js.
See
Examples/Volume/VolumeMapperLightAndShadow/index.jsfor an example that uses multiple volumes.See #3132 for the PR that is based on this PR, that adds multi component