Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quality of rendering with interactions #2876

Merged
merged 2 commits into from
Jul 31, 2023
Merged

Quality of rendering with interactions #2876

merged 2 commits into from
Jul 31, 2023

Conversation

bruyeret
Copy link
Contributor

Add two features to decrease quality of rendering during interaction

  • Add a function to set initial scale and avoid a slow first interaction at full resolution
  • Add a function to scale the sample distance when interacting to avoid an important decrease of resolution of viewport

@bruyeret
feat(volumeMapper): add a first interaction render quality setting
3a30879 
The setting "initialInteractionScale" set the quality of the rendering when interacting
@bruyeret bruyeret requested a review from finetjul July 20, 2023 15:54
@bruyeret bruyeret marked this pull request as ready for review July 31, 2023 12:32
@bruyeret
feat(volumeMapper): add an interaction sample distance factor
c0a61c3 
Its purpose is to increase the sample distance when interacting to increase
the framerate without sacrifying XY sample distance / viewport resolution
@bruyeret
Copy link
Contributor Author

I edited my commit to set the default initialInteractionScale and interactionSampleDistanceFactor to 1.0
Should be ready to merge if you don't have any other feedback @finetjul

@finetjul finetjul enabled auto-merge July 31, 2023 13:32
@finetjul finetjul added this pull request to the merge queue Jul 31, 2023
Merged via the queue into Kitware:master with commit 370e71c Jul 31, 2023
4 checks passed
@bruyeret bruyeret deleted the interaction-quality branch July 31, 2023 13:55
@github-actions
Copy link

🎉 This PR is included in version 28.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Automated label label Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@finetjul finetjul finetjul left review comments

Assignees
No one assigned
Labels
released Automated label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bruyeret @finetjul