[WB-1853] Button: Refactor theme to support semanticColor tokens #2431
+138
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0aa3431 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jandrade
changed the title
A new build was pushed to Chromatic! 🚀https://5e1bf4b385e3fb0020b7073c-mkzzciueot.chromatic.com/ Chromatic results:
|
|
Size Change: +296 B (+0.31%) Total Size: 96.9 kB
ℹ️ View Unchanged
|
added 3 commits
January 16, 2025 13:00
…This replaces the use of `color` primitive tokens in favor of semantic color tokens
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Now that we have
semanticColortokens available, this PR is responsible forrefactoring the existing
Buttoncode to use these tokens instead of thecolorprimitive tokens. Also, it modifies the theme structure to followcloser the semantic color tokens structure.
Also added a
light.destructive.disabledvariant to the Dark story as we didn'tinclude a snapshot for it.
Issue: WB-1853
Test plan:
Navigate to
/?path=/docs/packages-button--docsand verify that the buttonhasn't changed.