[Storybook] Configure Aphrodite to Not Append !important to Styles #2107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 14, 2025 15:10
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (4a233c9) and published it to npm. You Example: yarn add @khanacademy/perseus@PR2107If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR2107 |
|
Size Change: 0 B Total Size: 1.47 MB ℹ️ View Unchanged
|
jeremywiebe
approved these changes
Jan 15, 2025
added 3 commits
January 16, 2025 16:26
jeremywiebe
approved these changes
Jan 18, 2025
Comment on lines
+9
to
+10
| // Once the LESS files have cascade layers included (a more involved task for a later time), | ||
| // then the following plugin option should be removed. |
There was a problem hiding this comment.
Thanks for documenting the exit path. Do you think it's worth creating a ticket and noting it here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Aphrodite appends
!importantto all styling, by default. This is cumbersome for debugging and for writing appropriately defined rulesets. This configuration change causes Aphrodite to NOT append!important. This change is limited to our dev environments (i.e. Storybook). Webapp has already implemented this, and handles Perseus styling accordingly.Issue: LEMS-2227
Test plan:
!importantsuffixes.