-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix search input onChanged event #1459
base: dev
Are you sure you want to change the base?
Conversation
* Updating Readme according to KRTirtho#1082 Updating Readme according to KRTirtho#1082 * Added explanation The explanation is now given and the expression is more formal and explanatory, instead of just linking the issue.
Release version 3.6.0
There probably should be some debounce might hit rate limits |
cool, but i think it won't hit any rate limit or anything and adding a delay will only make the whole thing useless as then it would become same as typing the full word out and then hitting enter, but what im seeking is searching while every key is pressed, without any latency |
Yeah true I guess I would much prefer the songs to appear as I finish but not really as I type but don't know what the rate limits are because Spotify doesn't really say exactly it just says it's calculated maybe people might start hitting it for a bit and then it might resolve it self https://developer.spotify.com/documentation/web-api/concepts/rate-limits unless they don't use this API idk |
We've to debounce the user input. There's actually a hook named |
Also, it looks like there was merge conflict that wasn't properly resolved and caused all sorts of changes in unrelated files like pubspec.lock, desktop_login.dart and authentication_provider.dart. Please fix those. |
okay |
resolved issues ✔️ |
ahh doing that in a few days |
i am a spotify user and using that has a feature where while im typing the song name the songs keep appearing and it wasn't a case with spottube, so i removed a line where it was searching when enter key was pressed, and rather it was re-searching on every letter written, just like spotify