Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make broken tests less noisy #272

Merged
merged 8 commits into from
Apr 2, 2024

Conversation

lgoettgens
Copy link
Collaborator

Resolves #231.

The tests that may print long lists of things now only do that in the case of a failure. If the test is supplied broken=true, only the number of instances is printed instead.

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 63.63636% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 75.06%. Comparing base (6f3067c) to head (e6d4ab0).

Files Patch % Lines
src/piracies.jl 16.66% 5 Missing ⚠️
src/exports.jl 66.66% 3 Missing ⚠️
src/ambiguities.jl 83.33% 2 Missing ⚠️
src/unbound_args.jl 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #272      +/-   ##
==========================================
- Coverage   75.46%   75.06%   -0.41%     
==========================================
  Files          11       11              
  Lines         750      762      +12     
==========================================
+ Hits          566      572       +6     
- Misses        184      190       +6     
Flag Coverage Δ
unittests 75.06% <63.63%> (-0.41%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lgoettgens
Copy link
Collaborator Author

Is this how you imagined it @jishnub?

@jishnub
Copy link
Contributor

jishnub commented Apr 2, 2024

Yes, thanks, this looks exactly like what I wanted

@lgoettgens lgoettgens merged commit 02a7028 into JuliaTesting:master Apr 2, 2024
24 of 26 checks passed
@lgoettgens lgoettgens deleted the lg/broken-less-noisy branch April 2, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: summarize output for broken tests
2 participants