Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add numerator, denominator, terms and factors convenience functions #1445

Merged
merged 3 commits into from
Feb 20, 2025

Conversation

hersle
Copy link
Contributor

@hersle hersle commented Feb 20, 2025

I think it is convenient when fiddling around with expressions to easily get numerators/denominators.

These functions are defined in Base, so I think it would be natural to extend them to Symbolics.

@hersle
Copy link
Contributor Author

hersle commented Feb 20, 2025

For some "completeness", I also added factors() and terms() to make it more intuitive/convenient to fiddle with arithmetic expression in general.

Do you think they make sense? If not I will revert.

@hersle hersle changed the title Add numerator and denominator functions Add numerator, denominator, terms and factors functions Feb 20, 2025
@hersle hersle changed the title Add numerator, denominator, terms and factors functions Add numerator, denominator, terms and factors convenience functions Feb 20, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Project coverage is 8.83%. Comparing base (eced900) to head (9a9e0bb).
Report is 24 commits behind head on master.

Files with missing lines Patch % Lines
src/utils.jl 0.00% 20 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #1445      +/-   ##
=========================================
- Coverage    8.88%   8.83%   -0.05%     
=========================================
  Files          51      51              
  Lines        4876    4903      +27     
=========================================
  Hits          433     433              
- Misses       4443    4470      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisRackauckas ChrisRackauckas merged commit f919767 into JuliaSymbolics:master Feb 20, 2025
8 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants