-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use MKL 2025.0.1 in MKLSparse.jl #56
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #56 +/- ##
=======================================
Coverage 44.57% 44.57%
=======================================
Files 8 8
Lines 1494 1494
=======================================
Hits 666 666
Misses 828 828 ☔ View full report in Codecov by Sentry. |
Seems this doesn't support 32-bit anymore? |
Yes, Intel dropped the support of 32-bit platforms with the version 2025.x.x. |
Okay, I think it is fine to drop it here as well. |
Here's the Intel forum link regarding the 32bit support removal from onMKL 2025. I am also fine with dropping the 32bit support from MKLSparse.jl. I guess it warrants to tag the next minor version. |
@alyst Is it fine to tag the release 3.0.0 after this PR for you? |
@amontoison Yes, it is fine for me. I was also considering 3.0.0. Probably that's not so critical, unless there are MKLSparse.jl users on x86. |
I updated the JLL
MKL_jll.jl
.