Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use MKL 2025.0.1 in MKLSparse.jl #56

Merged
merged 2 commits into from
Jan 20, 2025

Conversation

amontoison
Copy link
Member

@amontoison amontoison commented Jan 20, 2025

I updated the JLL MKL_jll.jl.

@amontoison amontoison requested a review from alyst January 20, 2025 05:41
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.57%. Comparing base (8f67d95) to head (fac7897).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #56   +/-   ##
=======================================
  Coverage   44.57%   44.57%           
=======================================
  Files           8        8           
  Lines        1494     1494           
=======================================
  Hits          666      666           
  Misses        828      828           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KristofferC
Copy link
Member

Seems this doesn't support 32-bit anymore?

@amontoison
Copy link
Member Author

amontoison commented Jan 20, 2025

Yes, Intel dropped the support of 32-bit platforms with the version 2025.x.x.

@KristofferC
Copy link
Member

Okay, I think it is fine to drop it here as well.

@alyst
Copy link
Contributor

alyst commented Jan 20, 2025

Here's the Intel forum link regarding the 32bit support removal from onMKL 2025.
Strange that there is no explicit mention of it in the release notes (maybe 32bit is still available for the commercial licenses).

I am also fine with dropping the 32bit support from MKLSparse.jl. I guess it warrants to tag the next minor version.

@amontoison
Copy link
Member Author

@alyst Is it fine to tag the release 3.0.0 after this PR for you?

@amontoison amontoison merged commit 1540448 into JuliaSparse:master Jan 20, 2025
6 checks passed
@amontoison amontoison deleted the update_headers branch January 20, 2025 19:16
@alyst
Copy link
Contributor

alyst commented Jan 20, 2025

@amontoison Yes, it is fine for me. I was also considering 3.0.0. Probably that's not so critical, unless there are MKLSparse.jl users on x86.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants