Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test for invalidation #426

Merged
merged 5 commits into from
Sep 1, 2022
Merged

Add a test for invalidation #426

merged 5 commits into from
Sep 1, 2022

Conversation

timholy
Copy link
Contributor

@timholy timholy commented Aug 31, 2022

@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Base: 86.47% // Head: 86.47% // No change to project coverage 👍

Coverage data is based on head (2c3cbc7) compared to base (def5ad1).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #426   +/-   ##
=======================================
  Coverage   86.47%   86.47%           
=======================================
  Files          37       37           
  Lines        9306     9306           
=======================================
  Hits         8047     8047           
  Misses       1259     1259           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@chriselrod chriselrod enabled auto-merge (squash) August 31, 2022 22:42
@chriselrod
Copy link
Member

Thanks, this will be useful!
It'll also run automatically for packages that include LoopVectorization.jl in their downstream tests.

@chriselrod
Copy link
Member

chriselrod commented Aug 31, 2022

@timholy maybe there's a better way to run tests in parallel, but mind updating the ci workflows?

loopvectorization_test:
- part1
- part2
- part3
- part4
- part5

loopvectorization_test:
- part1
- part2
- part3
- part4
- part5

All you should have to do is add part6 to both of these.

@chriselrod chriselrod disabled auto-merge August 31, 2022 22:45
@chriselrod chriselrod enabled auto-merge (squash) September 1, 2022 13:24
@chriselrod
Copy link
Member

chriselrod commented Sep 1, 2022

  Activating project at `~/work/LoopVectorization.jl/LoopVectorization.jl/test/precompile`
ERROR: LoadError: ArgumentError: Package LoopVectorization [bdcacae8-1622-11e9-2a5c-532679323890] is required but does not seem to be installed:
 - Run `Pkg.instantiate()` to install all recorded dependencies.

@DilumAluthge what's the best way to make sure it finds the LV we're testing (or is there someone better to ask)?

@chriselrod chriselrod disabled auto-merge September 1, 2022 14:11
@timholy
Copy link
Contributor Author

timholy commented Sep 1, 2022

Thanks for adding it to CI, sorry I didn't get to it first.

@DilumAluthge
Copy link
Member

I would just add SnoopCompile and SnoopCompileCore as test dependencies, and get rid of the special "precompile" project.

@DilumAluthge
Copy link
Member

Why do you need to activate a separate project?

@timholy
Copy link
Contributor Author

timholy commented Sep 1, 2022

LoopVectorization is used to build LVUser, so LVUser's environment has to be able to find LoopVectorization. And then we load the LVUser package and test whether this caused invalidations.

@DilumAluthge
Copy link
Member

Hmmm. Might be cleaner to do this in a subprocess. Let me give this a bit of thought.

@timholy
Copy link
Contributor Author

timholy commented Sep 1, 2022

what's the best way to make sure it finds the LV we're testing

This version may fix it 🤞 because in the Manifest for LVUser I specify the path for LoopVectorizations as ../../...

@chriselrod chriselrod enabled auto-merge (squash) September 1, 2022 21:33
@chriselrod
Copy link
Member

Great, looks good, thank you!

@chriselrod chriselrod disabled auto-merge September 1, 2022 22:09
@chriselrod chriselrod merged commit 0f7b4f3 into JuliaSIMD:main Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants