-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a test for invalidation #426
Conversation
Codecov ReportBase: 86.47% // Head: 86.47% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #426 +/- ##
=======================================
Coverage 86.47% 86.47%
=======================================
Files 37 37
Lines 9306 9306
=======================================
Hits 8047 8047
Misses 1259 1259 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Thanks, this will be useful! |
@timholy maybe there's a better way to run tests in parallel, but mind updating the ci workflows? LoopVectorization.jl/.github/workflows/ci.yml Lines 36 to 41 in def5ad1
LoopVectorization.jl/.github/workflows/ci-julia-nightly.yml Lines 35 to 40 in def5ad1
All you should have to do is add part6 to both of these.
|
Activating project at `~/work/LoopVectorization.jl/LoopVectorization.jl/test/precompile`
ERROR: LoadError: ArgumentError: Package LoopVectorization [bdcacae8-1622-11e9-2a5c-532679323890] is required but does not seem to be installed:
- Run `Pkg.instantiate()` to install all recorded dependencies. @DilumAluthge what's the best way to make sure it finds the LV we're testing (or is there someone better to ask)? |
Thanks for adding it to CI, sorry I didn't get to it first. |
I would just add SnoopCompile and SnoopCompileCore as test dependencies, and get rid of the special "precompile" project. |
Why do you need to activate a separate project? |
LoopVectorization is used to build LVUser, so LVUser's environment has to be able to find LoopVectorization. And then we load the LVUser package and test whether this caused invalidations. |
Hmmm. Might be cleaner to do this in a subprocess. Let me give this a bit of thought. |
This version may fix it 🤞 because in the Manifest for |
Great, looks good, thank you! |
xref JuliaSIMD/CPUSummary.jl#3 (comment)