-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to ProximalAlgorithms v0.5 #40
Conversation
dhanak
commented
Jun 22, 2023
- drop support for ForwardBackward optimizer;
- add support for PANOCplus;
- make PANOCplus the default optimizer;
- stabilize unstable unit test.
Codecov Report
@@ Coverage Diff @@
## master #40 +/- ##
==========================================
+ Coverage 91.87% 92.24% +0.37%
==========================================
Files 16 17 +1
Lines 480 503 +23
==========================================
+ Hits 441 464 +23
Misses 39 39
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dhanak! I guess we can bump the dependency on AbstractOperators too.
I’m not entirely sure why we need to drop support for ForwardBackward?
Project.toml
Outdated
@@ -13,10 +13,10 @@ RecursiveArrayTools = "731186ca-8d62-57ce-b412-fbd966d074cd" | |||
|
|||
[compat] | |||
AbstractOperators = "0.1 - 0.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AbstractOperators = "0.1 - 0.2" | |
AbstractOperators = "0.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. In fact, I requested a version bump on AbstractOperators, I'm glad it went through so quickly.
ProximalAlgorithms dropped support for an external |
1 similar comment
ProximalAlgorithms dropped support for an external |
Please note that I won't be available in the next 10 days or so. |
* drop support for ForwardBackward optimizer; * add support for PANOCplus; * stabilize unstable unit test; * bump upper version limit on DSP.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dhanak!