Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make feedback2dof work for any system type #952

Merged
merged 2 commits into from
Jan 12, 2025
Merged

make feedback2dof work for any system type #952

merged 2 commits into from
Jan 12, 2025

Conversation

baggepinnen
Copy link
Member

No description provided.

@JuliaControlBot
Copy link

This is an automated message.
Plots were compared to references. 11/11 images have changed, see differences below.
After pulling this PR, please update the reference images by creating a PR to ControlExamplePlots.jl here.

Difference Reference Image New Image
❌ 0.047 Reference New
✔️ 0.011 Reference New
✔️ 0.001 Reference New
✔️ 0.001 Reference New
✔️ 0.007 Reference New
✔️ 0.003 Reference New
✔️ 0.0 Reference New
⚠️ 0.028 Reference New
❌ 0.06 Reference New
✔️ 0.0 Reference New
⚠️ 0.017 Reference New

Copy link

codecov bot commented Jan 12, 2025

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.81%. Comparing base (5982cc3) to head (a7cd0f0).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
lib/ControlSystemsBase/src/connections.jl 84.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #952      +/-   ##
==========================================
+ Coverage   92.79%   92.81%   +0.01%     
==========================================
  Files          41       41              
  Lines        4928     4938      +10     
==========================================
+ Hits         4573     4583      +10     
  Misses        355      355              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@baggepinnen baggepinnen merged commit 38afacc into master Jan 12, 2025
4 of 5 checks passed
@baggepinnen baggepinnen deleted the fb2dof branch January 12, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants