Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tools for counting multiple eigvals and adjust bode phase start #950

Merged
merged 2 commits into from
Jan 11, 2025

Conversation

baggepinnen
Copy link
Member

The Bode plot phase curve should now start at the correct phase, even when this is outside of [-180, 180] degrees.

@JuliaControlBot
Copy link

This is an automated message.
Plots were compared to references. 11/11 images have changed, see differences below.
After pulling this PR, please update the reference images by creating a PR to ControlExamplePlots.jl here.

Difference Reference Image New Image
❌ 0.047 Reference New
✔️ 0.011 Reference New
✔️ 0.001 Reference New
✔️ 0.001 Reference New
✔️ 0.007 Reference New
✔️ 0.003 Reference New
✔️ 0.0 Reference New
⚠️ 0.028 Reference New
❌ 0.06 Reference New
✔️ 0.0 Reference New
⚠️ 0.017 Reference New

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 78.78788% with 7 lines in your changes missing coverage. Please review.

Project coverage is 92.72%. Comparing base (fd44401) to head (96a92f8).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
lib/ControlSystemsBase/src/analysis.jl 94.11% 1 Missing ⚠️
lib/ControlSystemsBase/src/plotting.jl 83.33% 1 Missing ⚠️
lib/ControlSystemsBase/src/simplification.jl 66.66% 1 Missing ⚠️
lib/ControlSystemsBase/src/types/Lti.jl 0.00% 1 Missing ⚠️
lib/ControlSystemsBase/src/types/StateSpace.jl 0.00% 1 Missing ⚠️
...b/ControlSystemsBase/src/types/TransferFunction.jl 0.00% 1 Missing ⚠️
lib/ControlSystemsBase/src/types/conversion.jl 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #950      +/-   ##
==========================================
- Coverage   92.80%   92.72%   -0.08%     
==========================================
  Files          41       41              
  Lines        4879     4909      +30     
==========================================
+ Hits         4528     4552      +24     
- Misses        351      357       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@baggepinnen baggepinnen merged commit 273054e into master Jan 11, 2025
3 of 5 checks passed
@baggepinnen baggepinnen deleted the int_tools branch January 11, 2025 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants