Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make use of explicit rather than implicit imports of symbols #922

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

make use of explicit rather than implicit imports of symbols #922

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 18 additions & 7 deletions lib/ControlSystemsBase/src/ControlSystemsBase.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,26 +124,37 @@ export LTISystem,


# QUESTION: are these used? LaTeXStrings, Requires, IterTools
using RecipesBase, LaTeXStrings, LinearAlgebra
import Polynomials
import Polynomials: Polynomial, coeffs
import Base: +, -, *, /, (==), (!=), isapprox, convert, promote_op
import Base: getproperty, getindex
import Base: exp # for exp(-s)
import LinearAlgebra: BlasFloat

export lyap # Make sure LinearAlgebra.lyap is available
export plyap
import Printf
import Printf: @printf, @sprintf
import DSP
import DSP: conv
using ForwardDiff
import MatrixPencils
using MacroTools
using MatrixEquations
using UUIDs # to load Plots in gangoffourplot
using StaticArraysCore, Polyester

## Explicit Imports
# ExplicitImports.print_explicit_imports(ControlSystemsBase; show_locations=false)
using ForwardDiff: ForwardDiff
using LaTeXStrings: LaTeXStrings, @L_str, latexstring
using LinearAlgebra: LinearAlgebra, Adjoint, Diagonal, I, LAPACK, Symmetric,
UniformScaling, UpperHessenberg, cholesky, cond, diag,
diagind, diagm, eigen, eigvals, factorize, hessenberg,
ishermitian, isposdef, issuccess, lmul!, lu, lu!, lyap,
mul!, norm, opnorm, pinv, qr, rank, rdiv!, schur, svd!,
svdvals, tr
using MacroTools: MacroTools
using MatrixEquations: MatrixEquations, arec, ared, lyapc, lyapd
using Polyester: Polyester
using PrecompileTools: PrecompileTools
using RecipesBase: RecipesBase, @recipe, @series, @userplot
using StaticArraysCore: StaticArraysCore, SArray, SMatrix, SVector, SizedArray
using UUIDs: UUIDs # to load Plots in gangoffourplot

abstract type AbstractSystem end

Expand Down
Loading