Interpolation API: switch interpolations to BSplineKit #85
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #76, Ref #75
To-dos
API Changes
For relevant boostrapped class of curves, there is a new kwarg
interpolation
which has two options currently:CubicSpline()
andLinearSpline()
. This should facilitate more advanced choices in the future such as #70. Example of change:Speed
This PR is almost as fast when
discount
, but about twice as slow to actually bootstrap.The
discount
is probably used much more frequently so the comporable speed is good.The bootstrapping shoud be able to be sped up using
interpolate!
from BSplineKit, and in general the implementation is a bit ad-hoc to add extrapolations to BSplineKit. The author of BSK thinks that it could be made more efficient.Benchmark script:
master
:This PR (linear interpolation):
And this PR, with cubic spline interpolation (not possible with non-evenly spaced points on Interpolations.jl):