fixes: resolving the bugs 2_6_0rc versions #1182
Open
+7
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Overview
This PR addresses the potential issue of additional_info being None during initialization by using an empty dictionary as a fallback.
Key changes:
- Updated the init method to safely merge additional_info with model_parameters.
- Prevents TypeError during dictionary unpacking when additional_info is None.
Reviewed Changes
| File | Description |
|---|---|
| langtest/langtest.py | Modified additional_info assignment to use an empty dict fallback |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
chakravarthik27
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a change to the
__init__method inlangtest/langtest.pyto handle the case whereadditional_infomight beNone.langtest/langtest.py: Modified theadditional_infoassignment to safely handle the case whereadditional_infoisNoneby using an empty dictionary as a fallback.Issues: