Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add integration to deepseek #1176

Merged
merged 4 commits into from
Feb 26, 2025

Conversation

chakravarthik27
Copy link
Collaborator

This pull request includes several significant changes to improve the functionality and robustness of the codebase. The most important changes include adding a new method to extract the final answer from text, handling exceptions more effectively, and updating parameters for model evaluation.

Enhancements to exception handling and text processing:

  • langtest/modelhandler/llm_modelhandler.py: Added the extract_final_answer method to process the text and extract the final answer for reasoning models, and modified the predict method to utilize this new method. Additionally, improved exception handling by raising a ValueError with a specific error message.

Updates to model evaluation parameters:

@chakravarthik27 chakravarthik27 self-assigned this Feb 18, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

langtest/utils/custom_types/sample.py:561

  • The newly added model_type parameter is passed directly to load_eval_model.model without any validation. Verify that the value from harness_config is compatible with the expected input type of load_eval_model.model.
model, hub, model_type=model_type, **model_parameters

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

@chakravarthik27 chakravarthik27 merged commit 36472dd into release/2.6.0 Feb 26, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants