Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for webpack5 #403

Merged
merged 2 commits into from
Dec 4, 2020
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -21,3 +21,4 @@ coverage
.current-env
.nyc_output
runtime/*.build.js
.vscode/launch.json
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v7.9.0
v12.0.0
5 changes: 3 additions & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ sudo: false
language: node_js

node_js:
- 8.10.0
- 12.0.0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not using the latest stable LTS version instead?

Suggested change
- 12.0.0
- 12.18.1

https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V12.md

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update 00f4fc2


branches:
except:
Expand All @@ -13,7 +13,8 @@ env:
- ISTANBUL_COVERAGE: yes

script:
- yarn bootstrap --env webpack-4
- nvm install 8.10.0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary to use a deprecated version and support of highly outdated webpack versions?

Suggested change
- nvm install 8.10.0
- nvm install 8.17.0

- sh scripts/build.sh webpack-4
- yarn lint
- yarn test:webpack-2
- yarn test:webpack-3
Expand Down
5 changes: 3 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,16 +50,17 @@ Please follow these steps to contribute effectively.
```

4. **Setup project** properly:
now u need install nvm

```bash
yarn bootstrap
sh scripts/build.sh
```

It will:
1. Install project dependencies.
2. Install git hooks.
3. Install dependencies for testing in `webpack-1` and `webpack-2` environments.
4. Set `webpack-2` environment as current.
4. Set `webpack-3` environment as current.

Don't use `yarn install` or `npm install`.

Expand Down
6 changes: 4 additions & 2 deletions env/webpack-1/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,16 @@
"file-loader": "^0.11.1",
"html-loader": "^0.4.5",
"html-webpack-plugin": "2.28.0",
"webpack": "1"
"webpack": "1",
"eslint": "^3.18.0"
},
"packagesToLink": [
"enhanced-resolve",
"extract-text-webpack-plugin",
"file-loader",
"html-loader",
"html-webpack-plugin",
"webpack"
"webpack",
"eslint"
]
}
Loading